Skip to content

Unpatch2 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024
Merged

Unpatch2 #159

merged 2 commits into from
May 8, 2024

Conversation

mattip
Copy link
Collaborator

@mattip mattip commented May 8, 2024

  • I updated the version in pyproject.toml and made sure it matches git describe --tags --abbrev=8 in OpenBLAS at the OPENBLAS_COMMIT

This PR:

  • removes the local patch
  • updates OpenBLAS to the commit after the patch was applied upstream
  • redoes the linking from the pkg-config file in the wheel to use the full name of the library, which on Linux is enough to no longer require LD_LIBRARY_PATH
  • adds rpath bits on macOS so linking from the pkg-config file no longer requires DYLD_LIBRARY_PATH

@mattip mattip merged commit 8817145 into MacPython:main May 8, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant